Skip to content

fix(datastreams): make TestProcessor/test_service_name_override deterministic #4517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bm1549 wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −5
Open

fix(datastreams): make TestProcessor/test_service_name_override deterministic #4517

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c51370
fix(datastreams): make TestProcessor/test_service_name_override deter…
bm1549 Mar 9, 2026
781b03c
ci: trigger CI re-run
bm1549 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions internal/datastreams/processor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,9 @@ func TestProcessor(t *testing.T) {

t.Run("test_service_name_override", func(t *testing.T) {
p := NewProcessor(nil, "env", "service", "v1", &url.URL{Scheme: "http", Host: "agent-address"}, nil)
tp := time.Now().Truncate(bucketDuration)
// Use a fixed time so the test is deterministic regardless of wall-clock speed.
tp := time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC).Truncate(bucketDuration)
p.timeSource = func() time.Time { return tp }
p.add(statsPoint{
serviceName: "service1",
edgeTags: []string{"type:edge-1"},
Expand Down Expand Up @@ -237,7 +239,7 @@ func TestProcessor(t *testing.T) {
ProcessTags: processtags.GlobalTags().Slice(),
Stats: []StatsBucket{
{
Start: uint64(tp1.Add(-10 * time.Second).UnixNano()),
Start: uint64(tp.Add(-10 * time.Second).UnixNano()),
Duration: uint64(bucketDuration.Nanoseconds()),
Stats: []StatsPoint{{
EdgeTags: []string{"type:edge-1"},
Expand All @@ -251,7 +253,7 @@ func TestProcessor(t *testing.T) {
Backlogs: []Backlog{},
},
{
Start: uint64(tp1.UnixNano()),
Start: uint64(tp.UnixNano()),
Duration: uint64(bucketDuration.Nanoseconds()),
Stats: []StatsPoint{{
EdgeTags: []string{"type:edge-1"},
Expand All @@ -276,7 +278,7 @@ func TestProcessor(t *testing.T) {
ProcessTags: processtags.GlobalTags().Slice(),
Stats: []StatsBucket{
{
Start: uint64(tp1.Add(-10 * time.Second).UnixNano()),
Start: uint64(tp.Add(-10 * time.Second).UnixNano()),
Duration: uint64(bucketDuration.Nanoseconds()),
Stats: []StatsPoint{{
EdgeTags: []string{"type:edge-1"},
Expand All @@ -290,7 +292,7 @@ func TestProcessor(t *testing.T) {
Backlogs: []Backlog{},
},
{
Start: uint64(tp1.UnixNano()),
Start: uint64(tp.UnixNano()),
Duration: uint64(bucketDuration.Nanoseconds()),
Stats: []StatsPoint{{
EdgeTags: []string{"type:edge-1"},
Expand Down
Loading