Fix concurrent access to enabled features in metrics forwarder - #3413
Closed
tbavelier wants to merge 1 commit into
Closed
Fix concurrent access to enabled features in metrics forwarder#3413tbavelier wants to merge 1 commit into
tbavelier wants to merge 1 commit into
Conversation
The metrics forwarding loop could iterate over EnabledFeatures while a reconciliation updated the map, causing a fatal concurrent map iteration and map write error. Clone the map under a read lock and iterate over the snapshot, avoiding concurrent access without holding the lock while sending metrics. This fix doesn't fix the potential of map value slices concurrent modifications, however, that scenario is currently not present in the code as the values are set as whole slices and guarded by the setEnabledFeatures(..) function.
tbavelier
force-pushed
the
tbavelier/fix-mf-race
branch
from
September 1, 2026 12:37
f2d08cc to
043ed82
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Closing, was only done to trigger CI on the contributor commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply the fix from #3412 to snapshot
EnabledFeaturesunder a read lock before iterating and sending feature metrics. This prevents concurrent map iteration/write crashes without holding the lock during network calls.Validation
make buildmake ci-testmake update-golang