-
Notifications
You must be signed in to change notification settings - Fork 131
[CONTINT-5028] Add permissions to collect Argo and Flux CRDs #2470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2470 +/- ##
=======================================
Coverage 37.98% 37.99%
=======================================
Files 298 298
Lines 25029 25032 +3
=======================================
+ Hits 9508 9511 +3
Misses 14796 14796
Partials 725 725
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
817bf36 to
981765b
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 90234803 took longer than expected. The current limit for the base branch 'main' is 120 minutes. Possible reasons:
|
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
What does this PR do?
Add permission to collect Argo and Flux resources to later use them for resource origin detection
Motivation
https://docs.google.com/document/d/1nwCcBFXdQ-5rZRYyaw4yvDec-jDBOIQybUxGpESUo8Y/edit?pli=1&tab=t.0#heading=h.ke1ebayn7jv
Additional Notes
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
k auth can-i <test RBAC>as DCA service account (or cluster check runners if cluster checks runner is used): e.g.k auth can-i list applications.argoproj.io --as=system:serviceaccount:system:datadog-agent-cluster-checks-runner(replace namespace, SA) or describe the orchestrator clusterrole and veirfy it includes these permissionsChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel