Skip to content

Conversation

@bitomaxsp
Copy link
Contributor

@bitomaxsp bitomaxsp commented Jan 8, 2026

What does this PR do?

Add permission to collect Argo and Flux resources to later use them for resource origin detection

Motivation

https://docs.google.com/document/d/1nwCcBFXdQ-5rZRYyaw4yvDec-jDBOIQybUxGpESUo8Y/edit?pli=1&tab=t.0#heading=h.ke1ebayn7jv

Additional Notes

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  • Deploy DDA with orch explorer enabled (which is default)
  • "Install" ArgoCD https://argo-cd.readthedocs.io/en/stable/getting_started/
  • Run k auth can-i <test RBAC> as DCA service account (or cluster check runners if cluster checks runner is used): e.g. k auth can-i list applications.argoproj.io --as=system:serviceaccount:system:datadog-agent-cluster-checks-runner (replace namespace, SA) or describe the orchestrator clusterrole and veirfy it includes these permissions

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@bitomaxsp bitomaxsp requested a review from a team as a code owner January 8, 2026 14:03
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.99%. Comparing base (c73c418) to head (6564458).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2470   +/-   ##
=======================================
  Coverage   37.98%   37.99%           
=======================================
  Files         298      298           
  Lines       25029    25032    +3     
=======================================
+ Hits         9508     9511    +3     
  Misses      14796    14796           
  Partials      725      725           
Flag Coverage Δ
unittests 37.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../datadogagent/feature/orchestratorexplorer/rbac.go 100.00% <100.00%> (ø)
internal/controller/datadogagent_controller.go 66.66% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c73c418...6564458. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bitomaxsp bitomaxsp self-assigned this Jan 9, 2026
@bitomaxsp bitomaxsp added the enhancement New feature or request label Jan 9, 2026
@tbavelier
Copy link
Member

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 12, 2026

View all feedbacks in Devflow UI.

2026-01-12 16:15:33 UTC ℹ️ Start processing command /merge


2026-01-12 16:16:01 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-01-12 18:16:55 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 90234803 took longer than expected. The current limit for the base branch 'main' is 120 minutes.

Possible reasons:

  • some status checks are failing:
    • dd-gitlab/e2e: [1.19]
    • dd-gitlab/e2e: [1.22]
    • dd-gitlab/e2e: [1.29]
    • dd-gitlab/e2e: [1.26]
    • dd-gitlab/e2e: [1.24]
    • dd-gitlab/e2e: [1.25]
    • dd-gitlab/e2e: [1.32]
    • dd-gitlab/e2e: [1.30]

@tbavelier
Copy link
Member

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jan 13, 2026

View all feedbacks in Devflow UI.

2026-01-13 07:49:13 UTC ℹ️ Start processing command /merge


2026-01-13 07:49:18 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-01-13 08:08:11 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-01-13 09:58:05 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants