-
Notifications
You must be signed in to change notification settings - Fork 131
Add new options field with OOMBumpRatio as the first option #2412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new options field with OOMBumpRatio as the first option #2412
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2412 +/- ##
=======================================
Coverage 38.09% 38.09%
=======================================
Files 299 299
Lines 25182 25182
=======================================
Hits 9594 9594
Misses 14853 14853
Partials 735 735
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| // requests: | ||
| // minAllowed: | ||
| // maxAllowed: | ||
| // recommendationOptions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking if we should include recommendations because it's not really tied to recommendations, technically it could applied in-cluster on top of recommendations.
What do you think about
options | settings:
outOfMemory:
increaseFactor: 20% (same syntax as `Deployment.MaxUnavailable`?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's good for me, I updated with the hierarchy. However, I kept the bumpUpRatio name and use of a multiplier for familiarity (with VPA) and to reduce confusion. but can go to percentages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to align with VPA then.
5c5a0e9 to
3093276
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
What does this PR do?
Adds a new optional options section to the DatadogPodAutoscalerSpec in the v1alpha2 API. This section initially contains an outOfMemory configuration with a bumpUpRatio field that defines the ratio to multiply memory by when OOM events are detected.
Example usage:
Motivation
Support memory scale-up configuration when out-of-memory events are detected, allowing users to specify how much to increase memory allocation in response to OOM kills.
Additional Notes
Minimum Agent Versions
N/A - This is an API-only change for the operator CRD.
Describe your test plan
Checklist