Avoid Windows integration cache upload failures on 6.53.x#53852
Draft
AliDatadog wants to merge 1 commit into
Draft
Avoid Windows integration cache upload failures on 6.53.x#53852AliDatadog wants to merge 1 commit into
AliDatadog wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Windows MSI package builds on 6.53.x fail whenever an integration wheel is missing from the
dd-agent-omnibuscache. The Windows runner role can read the public cache but cannot upload a newly built wheel, and the existing cache-upload command treats S3AccessDeniedas a fatal package-build error.This change passes the existing
INTEGRATION_WHEELS_SKIP_CACHE_UPLOAD=trueguard into the Windows MSI build container. Cache reads remain enabled, cache misses are still built and installed locally, and only the optional upload is skipped.Why
Both Windows packaging jobs in PR #53401 reproduced the same failure for expired
active_directorycache entries:In both cases, the integration wheel built successfully and the job failed only when
dd-runner-windows-profileattempteds3:PutObject. Retrying cannot repair the cache because every observed Windows MSI runner uses the same unauthorized role.Validation
git diff --checkyqdda inv lint-gitlabpassed all four preset contexts using a project-scoped tokenCI must exercise an MSI cache miss to prove the upload path is skipped; a cache-hit-only run is insufficient.