Skip to content

Comments

DT-2918: Get Terms of Service state from user instead of separate API call#3337

Open
rushtong wants to merge 5 commits intodevelopfrom
gr-DT-2918-skip-tos-api-call
Open

DT-2918: Get Terms of Service state from user instead of separate API call#3337
rushtong wants to merge 5 commits intodevelopfrom
gr-DT-2918-skip-tos-api-call

Conversation

@rushtong
Copy link
Contributor

Addresses

Front end work related to https://broadworkbench.atlassian.net/browse/DT-2918

Summary

This PR requires DataBiosphere/consent#2817

In the back end PR, the user status from Sam is now stored on the user object returned from the GET /api/user/me call which allows us to skip the API call we were making in ToS.getStatus

Note in this network tab that the extra diagnostics call seen in DataBiosphere/consent#2817 is no longer made. Note also that a user who has not accepted ToS is redirected to the ToS screen instead of their original intended location.

Screenshot 2026-02-20 at 4 22 05 PM Screenshot 2026-02-20 at 4 23 49 PM

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@sonarqubecloud
Copy link

@rushtong rushtong marked this pull request as ready for review February 23, 2026 18:21
@rushtong rushtong requested a review from a team as a code owner February 23, 2026 18:21
@rushtong rushtong requested review from kevinmarete and otchet-broad and removed request for a team February 23, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants