DT-2918: Get Terms of Service state from user instead of separate API call#3337
Open
DT-2918: Get Terms of Service state from user instead of separate API call#3337
Conversation
|
kevinmarete
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Addresses
Front end work related to https://broadworkbench.atlassian.net/browse/DT-2918
Summary
This PR requires DataBiosphere/consent#2817
In the back end PR, the user status from Sam is now stored on the user object returned from the
GET /api/user/mecall which allows us to skip the API call we were making inToS.getStatusNote in this network tab that the extra diagnostics call seen in DataBiosphere/consent#2817 is no longer made. Note also that a user who has not accepted ToS is redirected to the ToS screen instead of their original intended location.
Have you read Terra's Contributing Guide lately? If not, do that first.