Skip to content

feat: add "recommended" tag to metadata dictionary fields (#3062)#3065

Merged
NoopDog merged 1 commit into
mainfrom
fran/3062-recommended-tag
May 19, 2026
Merged

feat: add "recommended" tag to metadata dictionary fields (#3062)#3065
NoopDog merged 1 commit into
mainfrom
fran/3062-recommended-tag

Conversation

@frano-m
Copy link
Copy Markdown
Contributor

@frano-m frano-m commented May 19, 2026

Summary

Closes #3062.

Show the existing grey "Recommended" chip on data dictionary rows that map to RequirementLabel.RECOMMENDED, consistent with the existing Required (red) and Strongly Recommended (orange) tags.

The accessor buildRequired in viewModelBuilders/dataDictionaryMapper/accessorFn.ts was already returning RequirementLabel.RECOMMENDED for non-required / non-strongly-recommended rows, and REQUIREMENT_LABEL_COLOR[RECOMMENDED] was already mapped to CHIP_PROPS.COLOR.DEFAULT (grey). Only the row.original.required && guard at fieldCell.tsx:72 was blocking the chip render — removed.

  • components/DataDictionary/components/TableCell/components/FieldCell/fieldCell.tsx — drop the conditional, render the chip unconditionally.
  • components/DataDictionary/components/TableCell/components/FieldCell/utils.ts — strip the now-stale "Only called when required is truthy" line from buildRequired's JSDoc.

Test plan

  • Navigate to any metadata dictionary page. Confirm fields that previously had no chip now show a grey "Recommended" chip.
  • Confirm Required (red) and Strongly Recommended (orange) chips still render as before.
  • Visual: grey chip matches the colour weight of the existing red/orange chips (same variant=STATUS).

🤖 Generated with Claude Code

image

Closes #3062.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@frano-m frano-m requested a review from Copilot May 19, 2026 01:00
@frano-m frano-m marked this pull request as ready for review May 19, 2026 01:00
@NoopDog NoopDog merged commit d79869b into main May 19, 2026
1 of 2 checks passed
@frano-m frano-m review requested due to automatic review settings May 19, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "Recommended" tag to metadata dictionary fields

2 participants