feat: make expand on data dictionary more obvious (#3036)#3061
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the discoverability of row expand/collapse behavior in the Data Dictionary table by adding a left-side chevron indicator in FieldCell and a “Show more / Show less” textual affordance in DetailCell.
Changes:
- Added a rotating chevron icon to
FieldCellthat reflects expanded state. - Added an always-present “Show more / Show less” label at the bottom of
DetailCell. - Refactored
FieldCelllayout from MUIGridusage to CSS grid + MUIStack.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| components/DataDictionary/components/TableCell/components/FieldCell/fieldCell.tsx | Renders chevron indicator and updates layout wrappers for field rows. |
| components/DataDictionary/components/TableCell/components/FieldCell/fieldCell.styles.ts | Introduces grid-based layout, chevron styling/rotation, and Stack wrapper styling. |
| components/DataDictionary/components/TableCell/components/FieldCell/constants.ts | Replaces Grid props with Stack props for the location/name + required chips row. |
| components/DataDictionary/components/TableCell/components/DetailCell/detailCell.tsx | Adds “Show more / Show less” label that tracks expanded state. |
| components/DataDictionary/components/TableCell/components/DetailCell/detailCell.styles.ts | Styles the new label (underline) and applies responsive visibility rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
NoopDog
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two visual affordances on data dictionary rows to indicate row-level expandability:
FieldCell—KeyboardArrowRightRounded, rotates 90° on expand with a 150ms CSS transition. Wrapped in a newStyledFieldCellflex-row container; existing content moves into the innerStyledGrid.DetailCell— always-visible textual affordance; label swaps based onrow.getIsExpanded(). Rendered as styledTypography(not a<button>) since the row itself is the canonical click target.Click behaviour is unchanged: findable-ui's
handleToggleExpandedcontinues to handle row-level toggling.Accessibility:
aria-hidden— purely decorative icon, conveys no information beyond what the row's expanded state already exposes.Closes #3036.
Files
components/DataDictionary/components/TableCell/components/FieldCell/fieldCell.tsxcomponents/DataDictionary/components/TableCell/components/FieldCell/fieldCell.styles.ts(addedStyledFieldCell,StyledIconButton; trimmedStyledGridlayout responsibilities)components/DataDictionary/components/TableCell/components/DetailCell/detailCell.tsxcomponents/DataDictionary/components/TableCell/components/DetailCell/detailCell.styles.ts(addedStyledTypographyfor the Show More indicator)Test plan
npx tsc --noEmit,npm run lint,npm run check-formatpassnpm run build-dev:data-portalsucceeds/metadata/<dictionary>— chevron present on LHS of every row, rotates on expand; "Show More" / "Show Less" appears at the bottom ofDetailCelland swaps based on state; clicking either the row or the indicators toggles expandbpDownSm) — padding adjustments still apply via the outerStyledFieldCell🤖 Generated with Claude Code