feat: anvil explorer - add files.data_modality to the facets and tables (#4618) #4623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frano-m
force-pushed
the
fran/4618-data-modality
branch
from
06f8de0 to
5eb2776
Compare
Contributor
Author
|
@copilot fix the failing test please. |
Contributor
…es (#4618) (#4624) * Initial plan * fix: add FILE_DATA_MODALITY to selectable columns for all entity tables (#4618) Co-authored-by: frano-m <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: frano-m <[email protected]>
NoopDog
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4618.
This pull request adds support for displaying the "Data Modality" field for files across all major entity tables (Activities, BioSamples, Datasets, Donors, Files) in the AnVIL CMG UI. It introduces new configuration keys and labels, updates view model builders to aggregate and display data modality values, and removes some unused transformer functions related to activities. The changes ensure that users can view and filter by data modality in the UI tables, improving data discoverability and consistency.
Entity Table Enhancements:
files.data_modality) to the Activities, BioSamples, Datasets, Donors, and Files entity tables, with appropriate view builders and initial column visibility set to hidden. [1] [2] [3] [4] [5] [6]Configuration and Labeling:
category.ts, and updated the dev config to include the new field in the file category. [1] [2] [3]View Model and Response Types:
EntityResponsetype to unify response types for easier handling and updated view model builders to support aggregated data modality extraction and rendering for the new column. [1] [2] [3] [4]Transformer and Utility Cleanup:
These changes collectively improve the consistency and usability of data modality representation in the AnVIL CMG interface.