Skip to content

Comments

[DT-2983] Make adjustments to template for using methods on getting Java Record values.#2820

Merged
otchet-broad merged 1 commit intodevelopfrom
otchet-dt-2983-freemarker-adjustments-for-prod
Feb 23, 2026
Merged

[DT-2983] Make adjustments to template for using methods on getting Java Record values.#2820
otchet-broad merged 1 commit intodevelopfrom
otchet-dt-2983-freemarker-adjustments-for-prod

Conversation

@otchet-broad
Copy link
Contributor

@otchet-broad otchet-broad commented Feb 23, 2026

Addresses

https://broadworkbench.atlassian.net/browse/DT-2983

Summary

The stack trace values in production logs indicates an issue with obtaining values from Java Records. This seems counter to the Freemarker release notes here: https://freemarker.apache.org/docs/versions_2_3_33.html. These release notes indicate that Java Record values can be obtained as if they were bean values as long as the configuration is updated to point to v_2_3_33 (ours is!).

This PR:

  • Updates the Freemarker configuration to v_2_3_34
  • Adds parens to darCode accessor so that we don't assume magic in freemarker is working
  • Adds a test to verify the darCode value appears in the template output.

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@sonarqubecloud
Copy link

@otchet-broad otchet-broad marked this pull request as ready for review February 23, 2026 16:04
@otchet-broad otchet-broad requested a review from a team as a code owner February 23, 2026 16:04
@otchet-broad otchet-broad requested review from eweitz, fboulnois, kevinmarete and rushtong and removed request for a team February 23, 2026 16:04
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 👍🏽

Copy link
Contributor

@kevinmarete kevinmarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update any of the other templates?

@otchet-broad
Copy link
Contributor Author

@fboulnois - This is the only message we send that uses a class that extends Record. Other classes use Java objects that have getters.

@otchet-broad otchet-broad merged commit 40e3f84 into develop Feb 23, 2026
14 checks passed
@otchet-broad otchet-broad deleted the otchet-dt-2983-freemarker-adjustments-for-prod branch February 23, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants