chore: complete removal of ua-parser-js dependency#5007
Open
PascalThuet wants to merge 1 commit intoDash-Industry-Forum:developmentfrom
Open
chore: complete removal of ua-parser-js dependency#5007PascalThuet wants to merge 1 commit intoDash-Industry-Forum:developmentfrom
PascalThuet wants to merge 1 commit intoDash-Industry-Forum:developmentfrom
Conversation
ua-parser-js was replaced in src/ by a lightweight browser detection in Dash-Industry-Forum#4972 but the dependency itself was not removed. The only remaining active usage was in test/functional/src/Utils.js, which now uses CoreUtils.parseUserAgent() from src/core/Utils.js. Also removes commented-out ua-parser-js imports in the Capabilities unit test. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the work started in #4972, which replaced
ua-parser-jsinsrc/with a lightweightUtils.parseUserAgent()but left the dependency inpackage.json.UAParser()withCoreUtils.parseUserAgent()intest/functional/src/Utils.js(only remaining active usage)ua-parser-jsimports intest/unit/test/streaming/streaming.utils.Capabilities.jsua-parser-jsfrompackage.jsondependencies (-31 packages)Test plan
npm run test)🤖 Generated with Claude Code