Skip to content

Fix python3 warning in release script#2531

Merged
jwillemsen merged 1 commit intoDOCGroup:masterfrom
jwillemsen:jwi-python3warning
Apr 15, 2026
Merged

Fix python3 warning in release script#2531
jwillemsen merged 1 commit intoDOCGroup:masterfrom
jwillemsen:jwi-python3warning

Conversation

@jwillemsen
Copy link
Copy Markdown
Member

@jwillemsen jwillemsen commented Apr 15, 2026

* ACE/bin/make_release.py:

Summary by CodeRabbit

  • Style
    • Updated internal code formatting to follow best practices.

    * ACE/bin/make_release.py:
@jwillemsen jwillemsen changed the title Fix python3 warning Fix python3 warning in release script Apr 15, 2026
@jwillemsen
Copy link
Copy Markdown
Member Author

@Mergifyio backport ace6tao2

@jwillemsen jwillemsen merged commit 0e050b1 into DOCGroup:master Apr 15, 2026
34 of 37 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 03ad475f-f9f3-490b-9b9f-a8d9bbf02451

📥 Commits

Reviewing files that changed from the base of the PR and between f8c5e56 and d1f9db7.

📒 Files selected for processing (1)
  • ACE/bin/make_release.py

Walkthrough

Two regular expressions in make_release.py were updated to use raw-string literals instead of regular strings: bin_regex and a mask pattern within update_debianbuild(). No functional changes to the regex matching or substitution logic.

Changes

Cohort / File(s) Summary
Regex String Literal Updates
ACE/bin/make_release.py
Updated bin_regex and mask pattern to use raw-string literals (r"...") for improved regex readability and to avoid unnecessary escape sequences.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Raw strings for regex, oh what a treat!
No more escaping, the code looks so neat.
With r"..." at the start, the patterns align,
CodeRabbit cheers—this refactor's divine! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jwillemsen jwillemsen deleted the jwi-python3warning branch April 15, 2026 08:21
@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 15, 2026

backport ace6tao2

✅ Backports have been created

Details

jwillemsen added a commit that referenced this pull request Apr 15, 2026
Fix python3 warning in release script (backport #2531)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant