Skip to content

Minor test cleanup#2528

Merged
jwillemsen merged 2 commits intoDOCGroup:masterfrom
jwillemsen:jwi-transporttest
Apr 9, 2026
Merged

Minor test cleanup#2528
jwillemsen merged 2 commits intoDOCGroup:masterfrom
jwillemsen:jwi-transporttest

Conversation

@jwillemsen
Copy link
Copy Markdown
Member

@jwillemsen jwillemsen commented Apr 9, 2026

Summary by CodeRabbit

  • Tests
    • Cleaned up command-line argument handling in test utilities
    • Fixed syntax errors in test code

    * TAO/tests/Transport_Idle_Timeout/client_multiple.cpp:
    * TAO/tests/Transport_Idle_Timeout/client.cpp:
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 808d4554-37c0-4faa-b117-6d188cb8c4c0

📥 Commits

Reviewing files that changed from the base of the PR and between 80991c7 and 11b0ecb.

📒 Files selected for processing (2)
  • TAO/tests/Transport_Idle_Timeout/client.cpp
  • TAO/tests/Transport_Idle_Timeout/client_multiple.cpp

Walkthrough

Minor cleanup changes to test files in the Transport_Idle_Timeout directory: removed an unused command-line option character from argument parsing and eliminated a redundant semicolon from variable initialization.

Changes

Cohort / File(s) Summary
Test File Cleanup
TAO/tests/Transport_Idle_Timeout/client.cpp, TAO/tests/Transport_Idle_Timeout/client_multiple.cpp
Removed unused option 'l' from ACE_Get_Opt argument string; removed extra trailing semicolon from variable initialization statement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop along, clean as can be,
Semicolons and options, now set free!
One less char, one less punc',
Code so tidy, crunch by crunch!
Test files sparkle, stripped of fluff,
Polish and perfection—good enough!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Minor test cleanup' accurately reflects the changeset: removing unused options and redundant semicolons from test files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jwillemsen jwillemsen merged commit f9c693d into DOCGroup:master Apr 9, 2026
38 checks passed
@jwillemsen jwillemsen deleted the jwi-transporttest branch April 9, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant