Merged
Conversation
Contributor
MiranDMC
commented
Nov 8, 2025
- Reorganized contents of CVector.h
- Separated declarations from implementation
- Unified function names
- All functions are now inlined
- Added vector LERP functions
- Added unit tests project
9f98454 to
4e095f8
Compare
4e095f8 to
363e38a
Compare
Collaborator
|
A refactor sounds nice and all, but in my opinion having multiple implementations for the trilogy for the sake of keeping one constructor call the original game function isn't worth the pain of editing it in the future. One single CVector class with all the implementations inlined inside one header file shared across the trilogy, with macros to not implement it for IV sounds way more reasonable for such a drastic change. |
Contributor
Author
|
Removed game specific CVector implementations. In future same treatment should be done to the CVector2D, CMatrix etc. |
7fa33b3 to
6ff0e62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.