[int] Parameterise SQL in FileManager#8704
Merged
Merged
Conversation
fstagni
approved these changes
Jul 13, 2026
chrisburr
added a commit
that referenced
this pull request
Jul 13, 2026
Three defects introduced when FileManager.py was parameterised (PR #8704): - _findFileIDs: the per-directory clause opened '( DirID=%s AND FileName IN (' but only closed the IN list, leaving the outer parenthesis unbalanced once clauses were OR-joined -> syntax error on every lookup (breaks getReplicas and any LFN->FileID resolution). - _getRepIDsForReplica: '(FileID,SEID) IN (' was filled with ','.join(['%s,%s']*n), yielding a flat scalar list 'IN (1,2,3,4)' against a 2-column row constructor -> MySQL error 1241. Use '(%s,%s)' groups so it renders 'IN ((1,2),(3,4))', and guard the empty-input case. - __getFileIDReplicas: 'args = fileIDs' aliased the caller's list and args.extend(statusIDs) mutated it, so the backfill in _getFileReplicas inserted status ids as bogus FileID keys -> KeyError in getReplicas. Copy the list before extending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems I missed this commit when I prepared the last batch of them... (Part of #8547).
BEGINRELEASENOTES
*DataManagement
FIX: Parameterise SQL in FileManager
ENDRELEASENOTES