Voting power limits for dao-voting-native-staked#746
Open
ismellike wants to merge 5 commits intoDA0-DA0:developmentfrom
Open
Voting power limits for dao-voting-native-staked#746ismellike wants to merge 5 commits intoDA0-DA0:developmentfrom
ismellike wants to merge 5 commits intoDA0-DA0:developmentfrom
Conversation
Added 2 new macros for limitable voting modules Added an error for LimitExceeded when attempting to stake more than allowed Added test case for limits Solution is optimistic hence the map instead of snapshotmap for limits, so reducing limit after a user has already staked will not be affected DA0-DA0#684 Also fixed some clippy errors
JakeHartnell
reviewed
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 2 new macros for limitable voting modules
Added an error for LimitExceeded when attempting to stake more than allowed Added test case for limits
Solution is optimistic hence the map instead of snapshotmap for limits, so reducing limit after a user has already staked will not be affected #684 Also fixed some clippy errors