Skip to content

Stop leaking internal exception messages to client in MeiliSearchView.getuid #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t0kubetsu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop leaking internal exception messages to client in MeiliSearchView.getuid #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions webapp/app/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,8 +614,9 @@ def getuid(self):
try:
result = index.get_document(uid)
return jsonify(vars(result)) # doc is already a dict-like
except Exception as e:
return jsonify({"error": str(e)}), 404
except Exception:
logger.exception("Error fetching Meilisearch document uid=%s", uid)
return jsonify({"error": "Document not found"}), 404


class KVSearchView(BaseView):
Expand Down