Skip to content

feat: created new troubleshoot component#352

Open
Ishaan28malik wants to merge 17 commits intodevelopfrom
feature/TroubleShootDialog
Open

feat: created new troubleshoot component#352
Ishaan28malik wants to merge 17 commits intodevelopfrom
feature/TroubleShootDialog

Conversation

@Ishaan28malik
Copy link
Contributor

@Ishaan28malik Ishaan28malik commented Dec 26, 2023

Added new Dialog for USBTroubleShoot

@changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2023

🦋 Changeset detected

Latest commit: 30c44f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@cypherock/cysync-core Patch
@cypherock/cysync-ui Patch
@cypherock/cysync-desktop-ui Patch
@cypherock/cysync-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Ishaan28malik Ishaan28malik force-pushed the feature/TroubleShootDialog branch from 520556c to bacda42 Compare December 27, 2023 11:13
@Ishaan28malik Ishaan28malik marked this pull request as ready for review January 2, 2024 21:03
@Ishaan28malik Ishaan28malik force-pushed the feature/TroubleShootDialog branch from 35f4ac4 to 0fcad44 Compare January 3, 2024 08:28
@Ishaan28malik Ishaan28malik force-pushed the feature/TroubleShootDialog branch from ca04952 to 428c01c Compare January 4, 2024 20:31
Copy link
Collaborator

@irshadCypherock irshadCypherock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Alignment issues
image

onPrevious: React.MouseEventHandler<HTMLButtonElement>;
isFirstDialog?: boolean;
}
export const UsbTroubleShootDialogBox: FC<UsbTroubleShootDialogBoxProps> = ({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is almost a duplicate of GuidedFlowDialogBox. Prefer reusing the same component to avoid duplicate code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created a reusable component as CustomFloeDialogBox

Comment on lines 128 to 135
return (
<WaitingDiv
key={`${type}-${index + 1}`}
text={messageBox[key]}
textColor={textColor}
type={type}
/>
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes that all the messageBoxList element should be displayed with a loader, which might not be true.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Didn't understood @irshadCypherock

@Ishaan28malik Ishaan28malik self-assigned this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants