feat: created new troubleshoot component#352
Open
Ishaan28malik wants to merge 17 commits intodevelopfrom
Open
Conversation
🦋 Changeset detectedLatest commit: 30c44f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
520556c to
bacda42
Compare
irshadCypherock
requested changes
Dec 28, 2023
packages/cysync-core/src/dialogs/TroubleShoot/Dialogs/CloseConfirmation.tsx
Outdated
Show resolved
Hide resolved
packages/cysync-core/src/dialogs/TroubleShoot/context/index.tsx
Outdated
Show resolved
Hide resolved
packages/cysync-core/src/dialogs/TroubleShoot/context/index.tsx
Outdated
Show resolved
Hide resolved
packages/cysync-core/src/dialogs/TroubleShoot/context/index.tsx
Outdated
Show resolved
Hide resolved
35f4ac4 to
0fcad44
Compare
ca04952 to
428c01c
Compare
irshadCypherock
requested changes
Jan 8, 2024
packages/cysync-core/src/pages/MainApp/Settings/Tabs/AppSettings.tsx
Outdated
Show resolved
Hide resolved
| onPrevious: React.MouseEventHandler<HTMLButtonElement>; | ||
| isFirstDialog?: boolean; | ||
| } | ||
| export const UsbTroubleShootDialogBox: FC<UsbTroubleShootDialogBoxProps> = ({ |
Collaborator
There was a problem hiding this comment.
This component is almost a duplicate of GuidedFlowDialogBox. Prefer reusing the same component to avoid duplicate code.
Contributor
Author
There was a problem hiding this comment.
created a reusable component as CustomFloeDialogBox
Comment on lines
128
to
135
| return ( | ||
| <WaitingDiv | ||
| key={`${type}-${index + 1}`} | ||
| text={messageBox[key]} | ||
| textColor={textColor} | ||
| type={type} | ||
| /> | ||
| ); |
Collaborator
There was a problem hiding this comment.
This assumes that all the messageBoxList element should be displayed with a loader, which might not be true.
Contributor
Author
There was a problem hiding this comment.
This is Didn't understood @irshadCypherock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added new Dialog for
USBTroubleShoot