ci: drop E2E job from PR checks until the suite is CI-ready#199
Merged
Conversation
The Playwright E2E suite runs fully serially (`workers: 1`, 156 tests) and takes ~45-60 min, and is timeout-fragile against the un-optimized dev server, so it cannot reliably gate PRs today — it only tripped its own 20-min timeout on every run. Remove the `e2e` job so PR CI is the fast, reliable Build/Lint/Test gate. The suite is unchanged and still runs locally via `bun run test:e2e`; it will return as its own sharded/parallelized workflow once stabilized. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQimijBDYixvpHp2HRiSJu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
E2Ejob from the PR CI workflow (.github/workflows/ci.yml), leaving Build & Typecheck / Lint / Test as the fast, reliable PR gate.Why
When the workflow was first exercised (on PRs #183, #182, #174), the E2E job failed on every run — but not because of those PRs. Two suite-level problems make it unfit to gate PRs today:
workers: 1,fullyParallel: false, 156 tests) and needs ~45–60 min. It only ever reached ~1/3 of the suite before tripping its own 20-min timeout, so it would be cancelled even if every test passed.admin-navigation,ai,capabilities) failed identically across three unrelated PRs, which points at the suite/environment rather than the changes. The failures cluster on editor/canvas-dependent specs racing 20s timeouts against the un-optimized dev server (the "6.5× faster dev boot" work is not merged yet).Rather than block every PR on a slow, pre-existing-red suite, drop it from CI for now. Build/Lint/Test give the reliable signal today.
Impact
Build & Typecheck,Lint,Testonly.bun run test:e2e.ci.ymlrecords why E2E is absent and that it will return as its own sharded/parallelized workflow once stabilized.Verification
ci.ymlparses; jobs are nowbuild,lint,test.🤖 Generated with Claude Code
Generated by Claude Code