Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...est/java/tech/pegasys/teku/spec/logic/versions/fulu/helpers/MiscHelpersFuluPropertyTest.java
Outdated
Show resolved
Hide resolved
...est/java/tech/pegasys/teku/spec/logic/versions/fulu/helpers/MiscHelpersFuluPropertyTest.java
Show resolved
Hide resolved
| } catch (final Exception ex) { | ||
| throw new KZGException( | ||
| "Failed to compute KZG cells and proofs for blob " + blob.toShortHexString(), ex); | ||
| } |
There was a problem hiding this comment.
Inconsistent try-catch scope in computeCellsAndProofs post-processing
Low Severity
In computeCellsAndProofs, the KZGCell.splitBytes and KZGProof.splitBytes calls (line 176-177) are outside the try-catch, while in both computeCells (line 161, inside try-catch) and recoverCellsAndProofs (lines 224-225, inside try-catch) the equivalent post-processing is wrapped. This inconsistency means any exception from splitBytes in computeCellsAndProofs would propagate unwrapped rather than as a KZGException, breaking the contract expected by the fuzzBlobToCellsAndProofs property test.
Contributor
Author
There was a problem hiding this comment.
post-processing doesn't depends on user data, so it shouldn't be a big issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Based on #10335 and requires it to be merged first
Property tests with 10 tries instead of 100 are heavy on memory consumption, so I decrease a number of runs rapidly. Not sure it's a right way to go.
UPDATE: removed all tests which usually cause java heap OOM
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Mostly test-only additions, but it changes
CKZG4844exception handling around native JNI calls, which could affect runtime error reporting/behavior in KZG operations.Overview
Adds new jqwik property tests for Fulu
Cell,DataColumn, andDataColumnSidecarto validate JSON/SSZ round-trips and ensure deserialization of mutated inputs fails as expected.Introduces additional Fulu fuzz/property tests for
CKZG4844andMiscHelpersFuluthat exercise cell computation, batch verification/recovery, and data-column sidecar verification paths while asserting failures surface asKZGException/IllegalArgumentException.Supports the new generators by adding multiple test-fixture
Supplierclasses and extendingDataStructureUtilwith conveniencerandomCell()/randomDataColumn()helpers; also exposesKzgResolverpublicly and hardensCKZG4844JNI wrappers to consistently convert native exceptions into clearerKZGExceptions forcomputeCellsAndProofs,verifyCellProofBatch, andrecoverCellsAndProofs.Written by Cursor Bugbot for commit ebe93f0. This will update automatically on new commits. Configure here.