geth: add new update transitions helper utility#1691
Open
rodion-lim-partior wants to merge 1 commit intoConsensys:masterfrom
Open
geth: add new update transitions helper utility#1691rodion-lim-partior wants to merge 1 commit intoConsensys:masterfrom
rodion-lim-partior wants to merge 1 commit intoConsensys:masterfrom
Conversation
rodion-lim-partior
force-pushed
the
add_update_transitions_cmd
branch
from
a381f46 to
4431884
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transitions for IBFT and QBFT are configurations stored under genesis block. Genesis block are written when
geth initis called. There are many instances when new transitions are introduced which does not require an entire rewrite of the rest of the chain configuration, nor the genesis block.This PR introduces an additional helper method,
geth updateto allow for the selective updates of only transitions to be written down to chain configuration. This reduces the number of configurations which might be unintentionally updated when callinggeth init, and also makes it clearer to the user on how to add transitions to an existing network.