Conversation
YaoJGalteland
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update golangci-lint version in CI. Also fix errors found by new linter.
Note
Medium Risk
Medium risk because it changes P-256 hint/table generation from
crypto/elliptictognark-crypto(could affect curve scalar-mul results) alongside CI/lint upgrades; remaining changes are mostly tooling and lint suppressions.Overview
CI/tooling: Updates PR/push workflows to pin GitHub Actions versions/SHAs, centralize
abigen/golangci-lintversions via env vars, and bumpgolangci-linttov2.10.1.Crypto/emulated curves: Reworks P-256 (
secp256r1) scalar-mul hint and precomputed table generation to usegnark-crypto(secp256r1) instead ofcrypto/elliptic, and adds targetednolintannotations (includingstaticcheckfor remaining P-384crypto/ellipticusage andgosecforPublic/Secretwire-name fields). Also bumps the modulegoversion from1.25.6to1.25.7.Written by Cursor Bugbot for commit 1226146. This will update automatically on new commits. Configure here.