Skip to content

chore: update CI workflows to go 1.25#1710

Merged
gbotrel merged 9 commits intomasterfrom
chore/go1.26
Feb 10, 2026
Merged

chore: update CI workflows to go 1.25#1710
gbotrel merged 9 commits intomasterfrom
chore/go1.26

Conversation

@gbotrel
Copy link
Copy Markdown
Collaborator

@gbotrel gbotrel commented Feb 10, 2026

update CI workflows to go 1.25


Note

Medium Risk
CI/tooling updates are low-risk but may affect build stability across runners, and the Go/toolchain + crypto dependency bumps plus prover/verification guard changes could impact proving behavior or performance if assumptions were previously relied upon.

Overview
CI/workflows: Update PR and push workflows to use Go 1.25.x, newer actions/checkout/setup-go, pinned tool versions, Go cache, and add workflow-level concurrency/minimal permissions. Tightens formatting checks by adding gofmt, improves go generate dirty-tree detection (ignoring go.mod/go.sum), upgrades golangci-lint action/version, sets push test matrix to 1.25.x with fail-fast: false, and removes Slack notification workflow wiring (and deletes slack-notifications.yml).

Code/deps: Bumps module go version to 1.25.6 and updates several deps (notably gnark-crypto, x/crypto, x/sys, pprof). Adds defensive validation in PLONK divideByZH (nil/zero/ratio domain checks) and in GKR verification to error on missing input-wire claims, tweaks tinyfield subtraction implementation, adjusts tinyfield sqrt benchmark input generation, fixes a small-rational Lagrange basis construction, and updates Eisenstein imports to the new gnark-crypto path. Also changes SHA-2 block compression to return a new hash state array instead of mutating currentHash in place.

Written by Cursor Bugbot for commit 415903e. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings February 10, 2026 20:39
@socket-security
Copy link
Copy Markdown

socket-security bot commented Feb 10, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Input argument leak: github gotesttools/gotestfmt-action exposes an input argument into sink

Location: Package overview

From: .github/workflows/pr.ymlgithub/gotesttools/gotestfmt-action@8b4478c7019be847373babde9300210e7de34bfb

ℹ Read more on: This package | This alert | What are GitHub Actions taint flows?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Validate and sanitize all input arguments before using them in dangerous operations. Use parameterized commands or APIs instead of string concatenation for shell commands.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore github/gotesttools/gotestfmt-action@8b4478c7019be847373babde9300210e7de34bfb. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Environment variable leak: github gotesttools/gotestfmt-action passes an environment variable into sink

Location: Package overview

From: .github/workflows/pr.ymlgithub/gotesttools/gotestfmt-action@8b4478c7019be847373babde9300210e7de34bfb

ℹ Read more on: This package | This alert | What are GitHub Actions taint flows?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Validate and sanitize environment variables before using them in dangerous operations. Ensure environment variables come from trusted sources only, and use parameterized commands or APIs instead of string concatenation.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore github/gotesttools/gotestfmt-action@8b4478c7019be847373babde9300210e7de34bfb. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s Go toolchain target and CI workflows to run on Go 1.25, and refines Slack CI notifications to report individual job outcomes.

Changes:

  • Bump module go version to Go 1.25.7.
  • Update GitHub Actions workflows (PR/push) to use Go 1.25.x and newer action versions, and bump golangci-lint configuration.
  • Improve Slack notification workflow to accept separate job statuses and send richer messages with run metadata.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
go.mod Updates the module go directive to Go 1.25.7.
AGENTS.md Adds repository guidelines for structure, testing, and CI/dev commands.
.github/workflows/slack-notifications.yml Reworks Slack workflow inputs/payload to reflect staticcheck + tests separately and include run details.
.github/workflows/push.yml Updates push workflow to Go 1.25.x and aligns Slack workflow invocation with new inputs.
.github/workflows/pr.yml Updates PR workflow to Go 1.25.x, refreshes tooling actions, and aligns Slack workflow invocation with new inputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go.mod
module github.com/consensys/gnark

go 1.24.9
go 1.25.6
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description says this is a CI workflow update, but it also changes the module's go directive. If the go.mod bump is intended (it impacts local builds and downstream users), please reflect that in the PR description/title or split it into a separate change.

Copilot uses AI. Check for mistakes.
Comment thread AGENTS.md

## Build, Test, and Development Commands

Use Go 1.24+ (CI runs on Go 1.23.x; module currently targets 1.24.9).
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AGENTS.md states CI runs on Go 1.23.x and the module targets 1.24.9, but this PR updates go.mod to Go 1.25.7 and workflows to Go 1.25.x. Please update this line to reflect the new supported/CI Go versions (or avoid hard-coding patch versions if you expect frequent bumps).

Suggested change
Use Go 1.24+ (CI runs on Go 1.23.x; module currently targets 1.24.9).
Use Go 1.25+ (CI and go.mod target Go 1.25.x).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Comment thread .github/workflows/slack-notifications.yml
@gbotrel gbotrel merged commit 51f3867 into master Feb 10, 2026
8 checks passed
@gbotrel gbotrel deleted the chore/go1.26 branch February 10, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants