Francescomiliani patch 1 fix sender amount recovering on event#70
Open
francescomiliani wants to merge 2 commits into
Conversation
Fix infinite ♾️ loop bug 🐛 in calculating value for transfer sender when receiving TransferOccured event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the infinite loop bug in calculating the value for the transfer sender when receiving the TransferOccured event produced as a result of a transfer.
In detail: during the transfer all listening clients receive and process the event, and only the involved parties will go to decrypt the value with secret x.
The bug consists of an infinite loop in the calculation of the value in the client of the sender of the transfer since the value to look for is negative, not positive, because it would never be found by blocking the application.
This bug is not apparent with Truffle since the statement in the client.js file.
event.returnValues['parties'] === null
returns in the sender client event.
In case the application is integrated into serious applications that listen for events and the clients are distributed son multiple machines, the problem becomes serious and very relevant.
Fixes the infinite loop bug in calculating the value for the transfer sender when receiving the TransferOccured event produced as a result of a transfer.
In detail: during the transfer all listening clients receive and process the event, and only the involved parties will go to decrypt the value with secret x.
The bug consists of an infinite loop in the calculation of the value in the client of the sender of the transfer since the value to look for is negative, not positive, because it would never be found by blocking the application.
This bug is not apparent with Truffle since the statement in the client.js file.
event.returnValues['parties'] === null
returns in the sender client event.
In case the application is integrated into serious applications that listen for events and the clients are distributed son multiple machines, the problem becomes serious and very relevant.
Solution: calculate the gB_neg that negative corresponding to - value, as well