Fix integer overflow in ParallelHelper.For range computation#1202
Open
sayantanmandal1 wants to merge 1 commit into
Open
Fix integer overflow in ParallelHelper.For range computation#1202sayantanmandal1 wants to merge 1 commit into
sayantanmandal1 wants to merge 1 commit into
Conversation
The range size was computed with 'Math.Abs(start - end)' using 32-bit arithmetic. For ranges larger than int.MaxValue this wraps around (silently running single-threaded) or throws OverflowException (Math.Abs(int.MinValue)). Compute the range and batch sizes with 64-bit arithmetic instead. Closes CommunityToolkit#1188
Author
@dotnet-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1188.
ParallelHelper.Forcomputed the range size withMath.Abs(start - end)in 32-bit arithmetic, which overflows for ranges larger thanint.MaxValue: the subtraction wraps around (silently running single-threaded) andMath.Abs(int.MinValue)throwsOverflowException. The range and batch sizes are now computed with 64-bit arithmetic; the per-iteration indices stay within[start, end]so the narrowing casts are safe. Added deterministic regression tests.Closes #1188