-
Notifications
You must be signed in to change notification settings - Fork 127
Disable DispatcherQueueHelper_Action_Null to patch random WinUI 3 test failures #817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Did we not want to do this on the crash #493 PR so if there's another failure we can get another dump? |
Good point. Given the stack trace we saw, I had enough confidence that this might fix it that I didn't plan for it to fail, focusing instead on separating concerns. I have a small script running locally to monitor the CI for this PR and rerun until completion, or to notify me on failure. If a failure is caught, we still have the option to close off #493 and bring those changes into here. |
|
Ah, looks like this didn't do it: #493 should close into |
|
Now Most of these are just the dummy tests we have as placeholders for basic construction of the control. It's like something within the structure of the tests themselves. |
|
Now the error has changed to this, which is... new.
This is suggesting that the crash happens because It doesn't tell us which test is dying anymore, either. Hmm. |


This PR follow up to the investigation enabled by #493 and aims to workaround the random WinUI 3 crash documented in #347 by disabling the offending test.
Since the random test failures took ~5 tries to get a successful failure and crash dump in #493, this PR will need to see at minimum 10 (max ~15) successful reruns before we can say we have confidence that it fixes the issue.