Replace RecursiveApply functions with AutoBroadcaster wrappers#2417
Open
dennisYatunin wants to merge 1 commit intomainfrom
Open
Replace RecursiveApply functions with AutoBroadcaster wrappers#2417dennisYatunin wants to merge 1 commit intomainfrom
dennisYatunin wants to merge 1 commit intomainfrom
Conversation
cc7a736 to
0b0cbe1
Compare
4 tasks
e603f47 to
5430722
Compare
30377bd to
92cf627
Compare
6e06ee4 to
cada7a8
Compare
800de37 to
630972d
Compare
5a61dc6 to
4486fee
Compare
4486fee to
0c351a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
RecursiveApplymodule with a new interface that follows the opposite design pattern: instead of defining functions forTuples andNamedTuples that need to be called inFields,Operators,MatrixFields, and sometimes even inClimaAtmos, we can now use a wrapper forTuples andNamedTuples that behaves the same way when passed to any standard math function. This should make it easy to decouple iteration over field variables from most of ClimaCore's internals.The new interface can be extended to any iterator type
Tby defining the methodis_auto_broadcastable(::T) = true, as long asTis compatible withUnrolledUtilities.jl. The@auto_broadcaster_argsannotation provides a convenient shorthand for extending the new interface to arbitrary functions ofNumbers orAbstractArrays, automatically broadcasting those functions overTuples,NamedTuples, andAutoBroadcasterss. This annotation can also be used to add methods for any other typeT, with the resulting behavior depending on whetheris_auto_broadcastableistruefor that type.