Add lang attribute to html tag in client participation page #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YumiChen
changed the title
…html tag in client participation page.
YumiChen
force-pushed
the
fix-Mandarin-text-announce-issue
branch
from
54fa704 to
ba9a6b5
Compare
NewJerseyStyle
merged commit 94e1362
into
CivicTechTO:edge-civictechto
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #132
langattribute tohtmltag in client participation pageui_langto participation page preload dataChecked lang attributes are added and screen reader could read Mandarin
Notes:
https://github.com/CivicTechTO/polis/actions/runs/14027611268/job/39268953969#step:6:703
Accept-Languageto language code instrings.jsto be a common util, so that we can include the subtags inlangattribute. We didn't use subtags inlangattributes before, thus leaving it to another PRhttps://github.com/CivicTechTO/polis/blob/edge-civictechto/client-participation/js/strings.js#L79