Skip to content

Unify parcel fromBody/updateFromBody into single declarative list reader#685

Open
danischm wants to merge 1 commit into
mainfrom
ds-authorative-parcel-lists
Open

Unify parcel fromBody/updateFromBody into single declarative list reader#685
danischm wants to merge 1 commit into
mainfrom
ds-authorative-parcel-lists

Conversation

@danischm
Copy link
Copy Markdown
Member

Replaces the dual fromBody + updateFromBody pattern across all profile parcel resources with a single fromBody(ctx, res, fullRead bool) method. Lists are now rebuilt from the API response on every read and reordered to match Terraform state (instead of iterating state items and looking them up individually in the API JSON). This makes the API response the authoritative source for list membership, preventing phantom state entries when items are removed server-side.

  • Template updated to generate unified fromBody with reorder blocks for lists
  • 5 hand-written model files migrated, preserving all backward-compat (<20.18) and tf_only inference customizations
  • 5 dead updateFromBody methods removed from ACL/traffic-policy files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant