Skip to content

[minor_change] Upgrade binary go version from 1.23 to 1.25 (DCNE-687)#1454

Merged
akinross merged 2 commits intoCiscoDevNet:masterfrom
akinross:1448_go_security_fix
Mar 27, 2026
Merged

[minor_change] Upgrade binary go version from 1.23 to 1.25 (DCNE-687)#1454
akinross merged 2 commits intoCiscoDevNet:masterfrom
akinross:1448_go_security_fix

Conversation

@akinross
Copy link
Copy Markdown
Collaborator

fixes #1448

@lhercot
Copy link
Copy Markdown
Member

lhercot commented Mar 19, 2026

Should we also bump this as minimal version everywhere? (go.mod,...)

@@ -51,6 +51,8 @@ jobs:
- name: Unshallow
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the go releaser check is having issues with the version bump.

@akinross
Copy link
Copy Markdown
Collaborator Author

Should we also bump this as minimal version everywhere? (go.mod,...)

Was considering it, but did only required parts first. @samiib agrees also so will change and align everything to same version.

@akinross akinross force-pushed the 1448_go_security_fix branch from 3c855c9 to 3dfbc4b Compare March 23, 2026 09:23
@akinross akinross changed the title [minor_change] Upgrade binary go version from 1.23 to 1.26 (DCNE-687) [minor_change] Upgrade binary go version from 1.23 to 1.25 (DCNE-687) Mar 23, 2026
@akinross akinross requested a review from samiib March 23, 2026 09:46
@akinross
Copy link
Copy Markdown
Collaborator Author

akinross commented Mar 23, 2026

@lhercot and @samiib, I decided to go with 1.25.8 since this fixes the security issue, is still supported go version and is the go version used in the hashicorp/terraform:latest container build.

I have added a comment to .goreleaser to take into consideration for when we bump to 1.26.

I also set go-version-file: 'go.mod' to assure the correct version is installed. This was already set in some of the setup-go step, in previous jobs and may be redundant when correct version is already installed. But think it is saver to pin on the step.

Copy link
Copy Markdown
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross akinross merged commit c9cadd0 into CiscoDevNet:master Mar 27, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ACI-as-Code Terraform Provider has NIST CVE (DCNE-687)

3 participants