Conversation
There was a problem hiding this comment.
Pull request overview
Adds GitHub Copilot tooling to the project’s devcontainer images so it’s available in both frontend and backend development environments.
Changes:
- Install
@github/copilotglobally via npm in the frontend devcontainer image. - Install
@github/copilotglobally via npm in the backend devcontainer image.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .devcontainer/frontend/dockerfile | Adds @github/copilot to the global npm tool install step. |
| .devcontainer/backend/dockerfile | Adds @github/copilot to the global npm/yarn tool install step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Update npm and install Codex CLI | ||
| RUN npm install -g npm@11.12.0 @openai/codex | ||
| RUN npm install -g npm@11.12.0 @openai/codex @github/copilot |
There was a problem hiding this comment.
PR title says "Add copilot-cli", but this change installs the npm package @github/copilot. If the intent is GitHub Copilot for the terminal, the commonly supported approach is the GitHub CLI extension (gh extension install github/gh-copilot) rather than an npm package; otherwise please update the PR title/description to match what’s actually being installed.
|
|
||
| # Update npm and install Codex CLI | ||
| RUN npm install -g npm@11.12.0 @openai/codex | ||
| RUN npm install -g npm@11.12.0 @openai/codex @github/copilot |
There was a problem hiding this comment.
This installs @github/copilot (and @openai/codex) without pinning a version, which makes the devcontainer image build non-reproducible and can break unexpectedly when upstream publishes a new release. Consider pinning these CLIs to explicit versions (or at least @github/copilot) similar to how npm itself is pinned.
| # Install Yarn, update npm, and install Codex CLI | ||
| RUN npm install -g yarn npm@11.12.0 @openai/codex | ||
| RUN npm install -g yarn npm@11.12.0 @openai/codex @github/copilot |
There was a problem hiding this comment.
This installs @github/copilot (and @openai/codex) without pinning a version, which makes the devcontainer image build non-reproducible and can break unexpectedly when upstream publishes a new release. Consider pinning these CLIs to explicit versions (or at least @github/copilot) similar to how npm itself is pinned.
No description provided.