Skip to content

add scamsniffer to security.csv#1074

Open
harunsulaiman wants to merge 5 commits intoChain-Love:mainfrom
harunsulaiman:securitya1
Open

add scamsniffer to security.csv#1074
harunsulaiman wants to merge 5 commits intoChain-Love:mainfrom
harunsulaiman:securitya1

Conversation

@harunsulaiman
Copy link
Copy Markdown
Contributor

Summary

Type of change

  • Add data rows
  • Update data rows
  • Remove data rows
  • Schema change
  • Documentation/metadata only

Scope

  • Networks affected:

  • Categories affected:

  • Additional notes, additional context / screenshots:

Links

  • Related issue(s)/ DB Improvement Proposal (if schema-related):

Validation checklist

  • I followed the Style Guide and Column Definitions. I'm aware of what is !provider syntax, and that entities in /networks sub-folders inherits records from /providers folder
  • I personally opened and verified every new link I'm adding. I can confirm, that all the links I'm adding are valid.
  • If I added new entries - I personally confirmed that the provider I'm adding (modifying) currently supports the adjusted network(s). I've also verified that value in every cell I'm changing is correct according to my best understanding
  • This PR is not a blind AI-generated submission

Optional

  • Rewards address (for data patching rewards):
  • Twitter (X) post link (for +10% of rewards to this PR):

@github-actions
Copy link
Copy Markdown

Summary

Status Count
🔍 Total 2
✅ Successful 2
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 0
❓ Unknown 0
🚫 Errors 0
⛔ Unsupported 0

Full Github Actions output

Copy link
Copy Markdown
Member

@USS-Supervisor USS-Supervisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for one blocking schema issue:

  • references/providers/providers.csv: new provider scam-sniffer sets logoPath=scam-sniffer.png, but this PR does not add references/providers/images/scam-sniffer.png.

Please add the missing image file (or point logoPath to an existing valid image) before merge.

@harunsulaiman
Copy link
Copy Markdown
Contributor Author

@USS-Supervisor changes made. re review

Copy link
Copy Markdown
Member

@USS-Supervisor USS-Supervisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review complete: I did not find blocking data-integrity issues in this diff, but the current review-cycle link-check result is missing. Per review policy, I can't approve until link-check is successful.

CI status: no required checks reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants