Merged
Conversation
miggol
approved these changes
Jul 1, 2025
Contributor
miggol
left a comment
miggol
left a comment
There was a problem hiding this comment.
Alright, I can't tell what was broken or reproduce the issue. But I trust you on this one :)
Member
Author
|
I'm also not entirely sure of the entire scope, I only know the alert stylings were missing. Probably other issues as well... Atm you can reproduce it at babex (till Ben pulls this fix ofc), by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was notified that the build of UU-Boostrap was broken on develop;
After some research, I figured out that this was due to a mistake on my part. Namely, I accidentally build the last version with a in-development version. (Instead of the latest UU-Bootstrap as released).
(In other words, I didn't realize I linked the dependency to a local version I was messing with).
This PR rebuilds the compiled bootstrap version with the actual intended SCSS. This restores some missing styles, but otherwise should not change anything.
It also updates
package.jsonto reference the new git-url of UU-bootstrap. (Which also added a corepack annotation; I left it there as it's best-practice to have that there)