Skip to content

[ENG-10737] Registrations are failing to auto-approve [privacy]#11718

Merged
cslzchen merged 2 commits into
CenterForOpenScience:feature/pbs-26-9from
antkryt:fix/ENG-10737
Jun 5, 2026
Merged

[ENG-10737] Registrations are failing to auto-approve [privacy]#11718
cslzchen merged 2 commits into
CenterForOpenScience:feature/pbs-26-9from
antkryt:fix/ENG-10737

Conversation

@antkryt
Copy link
Copy Markdown
Contributor

@antkryt antkryt commented Apr 28, 2026

Ticket

Purpose

fix check manual restart approval

Changes

  • schedule check_manual_restart_approval after force archive; remove it from archive_success
  • fix registration loading in the check_manual_restart_approval
  • use approve_past_pendings instead of process_manual_restart_approvals to approve a single registration
  • minor improvements
  • tests

Side Effects

QE Notes

CE Notes

Documentation

Copy link
Copy Markdown
Contributor

@mkovalua mkovalua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass done, left a few questions / suggestions 🔥

Comment thread osf/models/registrations.py
Comment thread osf/models/sanctions.py Outdated
Comment thread osf/management/commands/process_manual_restart_approvals.py Outdated
Comment thread scripts/check_manual_restart_approval.py
Comment thread scripts/check_manual_restart_approval.py Outdated
Comment thread scripts/check_manual_restart_approval.py Outdated
Comment thread scripts/check_manual_restart_approval.py
Comment thread website/archiver/tasks.py
Copy link
Copy Markdown
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cslzchen cslzchen merged commit 771a1ec into CenterForOpenScience:feature/pbs-26-9 Jun 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants