Merged
Conversation
rscipien
reviewed
Jan 27, 2026
| assertThat(role1.equals("")).isFalse(); | ||
| assertThat(role1.equals(role2)).isTrue(); | ||
|
|
||
| assertThat(role1.equals(role2)).isTrue(); |
| return result != 0 ? result : role1.getOwnerId().compareTo(role2.getOwnerId()); | ||
| }; | ||
|
|
||
| private final static Long zero = new Long(0); |
Contributor
There was a problem hiding this comment.
Could be replaced with Long.valueOf(0) to use cached value
| } | ||
|
|
||
| public boolean appliesTo(Class<? extends DvObject> aClass) { | ||
| for (Class<? extends DvObject> c : appliesTo) { |
Contributor
There was a problem hiding this comment.
Maybe throw IllegalArgumentException when aClass is null
I saw in unit test check for NPE
Contributor
Author
There was a problem hiding this comment.
Class.isAssignableFrom throws NPE if argument is null so Permission.appliesTo only fails to throws NPE for null argument when appliesTo array is empty which never happens
rscipien
approved these changes
Jan 27, 2026
added 14 commits
January 27, 2026 11:26
…lass, made it package private
lbownik
force-pushed
the
refactorings_22
branch
from
4593941 to
45dcdda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.