Skip to content

[DEVOPS-849] Refactor baking PR number into APK#131

Merged
juliajulie95 merged 1 commit intodevelopfrom
chege/DEVOPS-849
Aug 15, 2025
Merged

[DEVOPS-849] Refactor baking PR number into APK#131
juliajulie95 merged 1 commit intodevelopfrom
chege/DEVOPS-849

Conversation

@csongorhg
Copy link
Copy Markdown
Contributor

@csongorhg csongorhg commented Aug 12, 2025

Currently .github/workflows/update_app_identifiers.sh is corrupting the created APK on CI. I propose to simply echo the PR number to a txt file and include that in the APK. This PR also unblocks creating corrupted APK on CI.

After downloading the apk, one can see the PR number such as:

unzip flutter-paint-131.apk
cat ./assets/flutter_assets/assets/pr_number.txt
131

Ticket: https://catrobat.atlassian.net/browse/DEVOPS-849?atlOrigin=eyJpIjoiNjJlNzQwYWQyZjU3NGQ0Njk3ZGIzYzUyZGNhOGM2OTYiLCJwIjoiaiJ9

Refactorings and Bug Fixes

  • Unblock creating corrupt APK on CI

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Add the link to the ticket in Jira in the description of the PR
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines (Wiki)
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Add new information to the Wiki

@juliajulie95 juliajulie95 merged commit 5c83410 into develop Aug 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants