Fix XSS in Project.js createLinks() via innerHTML#6534
Open
Fix XSS in Project.js createLinks() via innerHTML#6534
Conversation
…nerHTML
Replace regex-based innerHTML replacement with safe DOM manipulation using
textContent, document.createElement('a'), and DocumentFragment to prevent
XSS injection via malicious project descriptions.
Closes #6510
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Use setAttribute with explicit protocol check to prevent CodeQL "DOM text reinterpreted as HTML" false positive on the href assignment. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
| } | ||
| const url = match[0] | ||
| const a = document.createElement('a') | ||
| a.setAttribute('href', /^(https?|ftp):\/\//i.test(url) ? url : '#') |
Check failure
Code scanning / CodeQL
DOM text reinterpreted as HTML High
Copilot Autofix
AI 13 days ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createLinks()(assets/Project/Project.js) whereinnerHTMLwith regex replacement allowed script injection through crafted project descriptionsinnerHTMLreplacement with safe DOM API: reads text viatextContent, builds anchor elements withdocument.createElement('a'), and assembles output usingDocumentFragmentTest plan
<script>tags or HTML are safely escapedweb-project-detailsBehat suiteCloses #6510
🤖 Generated with Claude Code