Implement state-based action buttons for experiment status changes #2810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TART implementation
This was
linked to
issues
Dec 19, 2025
…r paused experiments
zackcl
changed the title
This was
unlinked from
issues
Jan 6, 2026
danoswaltCL
reviewed
Jan 7, 2026
frontend/projects/upgrade/src/app/core/experiments/store/experiments.selectors.ts
Show resolved
Hide resolved
danoswaltCL
reviewed
Jan 7, 2026
frontend/projects/upgrade/src/app/core/experiments/store/experiments.selectors.ts
Show resolved
Hide resolved
danoswaltCL
reviewed
Jan 7, 2026
...omponents/common-section-card-action-buttons/common-section-card-action-buttons.component.ts
Show resolved
Hide resolved
Collaborator
|
i know you're still touching this up, I'm still reviewing since there's a lot here but scanning things from it looks pretty good. the one thing i think we should do though is handle the duplicate implementation of the pause-behavior form, they look and act nearly the same, that should be able to be one component without too much work. else we have change both any time we make a change. |
…-state-action-buttons
danoswaltCL
approved these changes
Jan 8, 2026
Collaborator
danoswaltCL
left a comment
danoswaltCL
left a comment
There was a problem hiding this comment.
cool, i think this is working and looks great, thx for the refactor to one component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the following sub-issues of #2735:
Implement Status-Based UI Restrictions #2809This will be resolved in a separate PRFor reference, I used the same "play_arrow" icon for the "Resume" button even though it differs from the original Figma design. I felt this worked better in practice.
This PR also reduces the left/right padding of the action buttons from 24px to 16px since they looked a bit better visually.