Skip to content

Conversation

@zackcl
Copy link
Collaborator

@zackcl zackcl commented Apr 4, 2025

Closed due to having too many conflicts. I opened another PR: #2353

Changes Include:

  • Added addSegmentList endpoint URL (/segments/list) to environment files
  • Added addSegmentList, updateSegmentList, and deleteSegmentList functions to segments.data.service.ts for making requests to the backend
  • Updated segments actions, effects, and reducer to support adding, updating, and deleting a segment list
  • Updated flagId to id in PrivateSegmentListRequest interface for supporting both feature flags and segments
  • Added unit tests for segment list operations to SegmentController.test.ts
  • Updated flagId to id in FeatureFlagListValidator for consistency with the frontend
  • Removed unused functions from feature-flag-exclusions-section-card.component.ts

Endpoints used for adding, updating, and deleting a segment list:

  1. On ADD:
    POST /segments/list

  2. On EDIT:
    POST /segment

  3. On DELETE:
    DELETE /segments/list/:segmentId

@zackcl zackcl requested review from bcb37 and danoswaltCL April 4, 2025 13:30
@zackcl zackcl self-assigned this Apr 4, 2025
@zackcl zackcl changed the title [WIP] Implement Add/Edit/Delete Segment List Modals [WIP] Implement Add/Edit Segment List Modals Apr 4, 2025
@zackcl zackcl changed the title [WIP] Implement Add/Edit Segment List Modals [WIP] Implement Add/Edit/Delete Segment List Modals Apr 4, 2025
@zackcl zackcl marked this pull request as ready for review April 8, 2025 10:13
@zackcl zackcl changed the title [WIP] Implement Add/Edit/Delete Segment List Modals Implement Add/Edit/Delete Segment List Modals Apr 8, 2025
@zackcl zackcl changed the title Implement Add/Edit/Delete Segment List Modals [WIP] Implement Add/Edit/Delete Segment List Modals Apr 8, 2025
@zackcl zackcl marked this pull request as draft April 8, 2025 11:13
@zackcl zackcl changed the title [WIP] Implement Add/Edit/Delete Segment List Modals Implement Add/Edit/Delete Segment List Modals Apr 8, 2025
@zackcl zackcl marked this pull request as ready for review April 8, 2025 13:08
@zackcl zackcl marked this pull request as draft April 8, 2025 13:42
@zackcl zackcl marked this pull request as ready for review April 8, 2025 14:54
@zackcl zackcl marked this pull request as draft April 8, 2025 17:14
@zackcl zackcl changed the title Implement Add/Edit/Delete Segment List Modals [WIP] Implement Add/Edit/Delete Segment List Modals Apr 8, 2025
@zackcl
Copy link
Collaborator Author

zackcl commented Apr 9, 2025

Closing due to having too many conflicts. I opened another PR: #2353

@zackcl zackcl closed this Apr 9, 2025
@zackcl zackcl changed the title [WIP] Implement Add/Edit/Delete Segment List Modals [Closed] Implement Add/Edit/Delete Segment List Modals Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants