Complete 3 out of 4 TODOs in code#4
Open
Santisoutoo wants to merge 5 commits intoCarlosBergillos:mainfrom
Open
Complete 3 out of 4 TODOs in code#4Santisoutoo wants to merge 5 commits intoCarlosBergillos:mainfrom
Santisoutoo wants to merge 5 commits intoCarlosBergillos:mainfrom
Conversation
…, and airline_codes
…nd airline_codes attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Parse StartupLocation metadata (row 1301)
The apt.dat format has an optional line after each startup location (row 1301)
that carries extra info: the width code, operation type, and airline codes.
Until now the parser was just throwing that data away. These fields are now
parsed and available as optional attributes on
StartupLocation.2. Fix bezier resolution not being forwarded in get_paths
The bezier_resolution argument is now passed as a parameter of
_calculate_bezier.3. Clear logged unknowns between airport parses
When parsing multiple airports in one session, unknown row codes seen in
the first airport kept showing up as warnings for every subsequent one.
The set of logged unknowns is now cleared between airports.