Add 'register' method to VertexSerializerRegistry#1924
Open
FlashyReese wants to merge 1 commit intoCaffeineMC:devfrom
Open
Add 'register' method to VertexSerializerRegistry#1924FlashyReese wants to merge 1 commit intoCaffeineMC:devfrom
FlashyReese wants to merge 1 commit intoCaffeineMC:devfrom
Conversation
This commit introduces a new 'register' method to the VertexSerializerRegistry interface, along with its implementation in the VertexSerializerRegistryImpl class. The 'register' method allows registering a custom VertexSerializer for a specific pair of source and destination VertexFormatDescriptions. When called, it creates an identifier based on the input formats and checks for an existing serializer in the cache. If a serializer already exists for the given formats, an IllegalArgumentException is thrown. Additionally, the 'serializer' parameter is validated to ensure it is not null. This new functionality provides greater flexibility for developers to define and use custom VertexSerializers, facilitating efficient vertex data transformations during rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new 'register' method to the VertexSerializerRegistry interface, along with its implementation in the VertexSerializerRegistryImpl class. The 'register' method allows registering a custom VertexSerializer for a specific pair of source and destination VertexFormatDescriptions. When called, it creates an identifier based on the input formats and checks for an existing serializer in the cache. If a serializer already exists for the given formats, an IllegalArgumentException is thrown. Additionally, the 'serializer' parameter is validated to ensure it is not null.
This new functionality provides greater flexibility for developers to define and use custom VertexSerializers, facilitating efficient vertex data transformations during rendering.