new: Add mixin rule override-ability, disable core overrides#1756
Open
FlashyReese wants to merge 1 commit intoCaffeineMC:devfrom
Open
new: Add mixin rule override-ability, disable core overrides#1756FlashyReese wants to merge 1 commit intoCaffeineMC:devfrom
core overrides#1756FlashyReese wants to merge 1 commit intoCaffeineMC:devfrom
Conversation
Contributor
|
Another option without changing the config system is to move it into a different mixin config (unless there's some dependency with others that causes issues). |
FlashyReese
force-pushed
the
mixin-config
branch
from
6eb8898 to
56140b9
Compare
Member
|
I'm going to take this out of the Sodium 0.5 milestone, but we'll re-visit it for when we switch to using CaffeineConfig. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows mixin override-ability to particular rules and disables
coremixin rule overrides.I'm unsure if I should port over Lithium's mixin config here or to mixin-config repository and then apply it here after it's on the CaffeineMC maven.