Alpha#36
Conversation
* add the new file * Default dependencies and optional dependencies: pyproject.toml * Default dependencies and optional dependencies: pyproject.toml * Remove legacy setup.py and setup.cfg * Default dependencies and optional dependencies: pyproject.toml * Add missing dependency * Updated file: tests * Fix test_pa for updated netin API (n, k, h_mm) and dependency typo * Add seaborn~=0.12.2 to dependencies * Add .venv* pattern to gitignore * deleted undirected_py * deleted .venv/ * deleted pyproject_py * removed duplicate classifiers,removed mentioned license * added packages * added some details for instance project description, maintainer, keywords, packages etc. * removed requirement folder --------- Co-authored-by: Diego Baptista Theuerkauf <dabtheuerkauf@gmail.com>
* Update undirected notebook to use new model API Rename parameters to match current API: - N -> n (number of nodes) - m -> k (number of edges per new node) - h_m -> h_mm (minority homophily) - h_M -> h_MM (majority homophily) * Update directed and inference notebooks to use new model API - directed.ipynb: N -> n for DPAModel, DHModel, DPAHModel - inference.ipynb: N -> n for PAHModel - undirected.ipynb: include notebook outputs
Moved all existing tests into a new directory " tests" and completed tox configuration.
…NetworkInequalities into feat/tests-notebook
Add nbmake support for notebook testing
* Fix line of installation * Fix target branch for GA and saved file * removed -r requirements.txt and used pip install -e.[test] * removed -r requirements.txt and used pip install -e.[test and pip install sphinx * removed -r requirements.txt and used pip install -e.[test], pip install sphinx numpydoc * removed extra dependencies and modified netin dependencies * removed version in sphinx * removed sphinx sutobuild version * removed versions from all dependencies * Stop tracking evidences.json notebook output (already in .gitignore) * Untrack pdfs * Add pdfs to gitignore * Stop building docs from any branch --------- Co-authored-by: Diego Baptista Theuerkauf <dabtheuerkauf@gmail.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mannbach
left a comment
mannbach
left a comment
There was a problem hiding this comment.
Thanks for the great work! Most things that I commented are straightforward fixes.
One additional thing: could you please clear the Jupyter notebook outputs in the commits? Otherwise, the git diffs get cluttered with non-code changes (metadata, figures btyecode, console outputs).
Once these things are done we can merge the changes :)
| publish_branch: documentation | ||
| destination_dir: / # Root folder for stable version | ||
|
|
||
| - name: Deploy alpha documentation |
There was a problem hiding this comment.
Removing this branch will only compile a single documentation. If we push to alpha, it might overwrite the default documentation. I would add it again until we finally merge alpha into main.
There was a problem hiding this comment.
Let me know if I'm missing something :)
|
|
||
| from .node_vector import NodeVector | ||
| from .categorical_node_vector import CategoricalNodeVector | ||
| from ..graphs.node_vector import NodeVector |
There was a problem hiding this comment.
Can we remove this? The node_vector.py script lives next to graphs.py, no?
| for s, t in edges]) | ||
| nx.draw_networkx_edges( | ||
| g, pos, ax=ax, | ||
| nx_graph, pos, ax=ax, |
|
|
||
| name = "netin" | ||
| description = "Python package to study inequalities in social networks" | ||
| version = "1.0.1" |
There was a problem hiding this comment.
i'd update the version to the alpha version 2.0.0a2. As soon as we merge into main, we can then set 2.0.0.
| authors = [ | ||
| { name = "Fariba Karimi", email = "karimi@csh.ac.at" }, | ||
| { name = "Lisette Espín-Noboa", email = "espin@csh.ac.at" }, | ||
| { name = "Jan Bachmann", email = "bachmann@csh.ac.at" }, |
| "Intended Audience :: Information Technology", | ||
| "Intended Audience :: Science/Research", | ||
| "Operating System :: OS Independent", | ||
| "Programming Language :: Python :: 3.9", |
There was a problem hiding this comment.
Can we remove the Python version or add all the newly supported versions?
3 participants
.github/workflows/documentation.yaml: We updated this workflow to use the docs setup and simplify when it runs, making documentation builds cleaner and easier to maintain..github/workflows/documentation.yaml: We updated this workflow to support multiple Python versions and separate linting and testing, making the CI more reliable and consistent..gitignore: We updated the .gitignore to keep the repository clean and avoiding unnecessary files in version control.examples/notebooks/: We changed the notebook to make it compatible with the alpha version.netin/viz/handlers.py: We renamed the variable to fix a bug.pyproject.toml: We restructured the pyproject.toml , to centralize dependencies, testing, and configuration settings, making the project easier to manage, install, and maintain consistently.tests/: We updated and moved the relevant test files outside the base folder and updated their imports, making the project structure cleaner and avoiding import issues.