Update fable, fix backing fields#56
Merged
Merged
Conversation
Member
|
Tests fail currently, I guess because a missing uv setup (maybe requirement resolving is missing). Could you check this, @caroott? |
Member
Author
Fable 5 changed Python output to import |
This reverts commit 7f60537.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates DynamicObj for Fable 5.1.0 and fixes JS/Python dynamic property handling.
Dynamic members are now stored and enumerated through the internal
Propertiesdictionary on Fable targets, so compiler-generated backing fields no longer leak throughGetProperties(false). This removes the previous native JS/Python attribute behavior for dynamic members.Changes
ResizeArraydeep-copy handling==andhash()match DynamicObj structural equality/hash