Open
Conversation
Contributor
Test Results 1 files - 3 1 suites - 3 34s ⏱️ - 2m 43s For more details on these failures and errors, see this check. Results for commit 7a550b0. ± Comparison against base commit 326ff41. This pull request removes 5 and adds 17 tests. Note that renamed tests count towards both.This pull request skips 1 test.♻️ This comment has been updated with latest results. |
Collaborator
|
Code Coverage (Ubuntu)DetailsDiff against developResults for commit: 7a550b0 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Collaborator
|
Code Coverage (Windows)DetailsDiff against developResults for commit: 2bf5dee Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Collaborator
|
sqlite database should not have dependency on |
anesson-cs
force-pushed
the
db-for-collections-storage
branch
4 times, most recently
from
398b63e to
2b23ed1
Compare
alambare
force-pushed
the
db-for-collections-storage
branch
from
aa5cc03 to
90fccc0
Compare
create a separate file to create SQLite functions which need to be registered as SQLite functions to be used during the queries implement most of the main methods of the class
…ion can be found with their key"
add an interface called 'Database'
collections returned in databases methods are dictionaries now, conversion to collection instances must be in the core
also refactor the sqlite and base codebase
perf fixes with cql2
fetch is a separated command
…at the init of the core and refactor some related topics rename provider to federation_backend in database files create an adapter and a converter for dicts use ellipsis in database abstract methods rename CollectionsDict.from_config() to CollectionsDict.from_configs()
also strong performances upgrades for spatial and temporal filtering
still need to update fetch_collection_list
required for stac-fastapi-eodag
this will prevent from errors between the sql request and its parameters this leads to have a set instead of a list of provider names in parameters of the method reorder by importance parameters in method signature do not set connection to None as it is not optional
anesson-cs
force-pushed
the
db-for-collections-storage
branch
from
91e0123 to
3715b40
Compare
except for deprecated core method 'available_providers()'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, a SQLite database is setup to store collections so they will not be kept in memory anymore. This will be particularly useful when eodag catalog will contain a big amount of collections.
Daily collections fetch is removed, which implies that users have to fetch collections by themselves (by calling the fetch method).