Add reproducer test for IGC miscompilation of aligned struct byval args#1185
Draft
Add reproducer test for IGC miscompilation of aligned struct byval args#1185
Conversation
…val args (#1180) Minimal test that demonstrates IGC codegen bug: when __align__(64) structs are passed by value to a kernel and their fields are loaded into double4 vectors via make_double4() and used in arithmetic with other byval double4 parameters, fields s4-s7 incorrectly read the values of s0-s3. This is an upstream IGC bug (chipStar generates correct LLVM IR with byval align 64).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestHeCBenchFluidSim.hipthat demonstrates the issue__align__(64)structs are passed by value to a kernel and their fields are loaded intodouble4viamake_double4()and used in arithmetic with other byvaldouble4parameters, IGC miscompiles — fields s4-s7 get the values of s0-s3byval(%struct.double8) align 64); the issue is in IGC's backendTest plan