Skip to content

Add edep tally and update neutron functions#383

Open
melekderman wants to merge 2 commits intoCEMeNT-PSAAP:devfrom
melekderman:feature/edep-tally
Open

Add edep tally and update neutron functions#383
melekderman wants to merge 2 commits intoCEMeNT-PSAAP:devfrom
melekderman:feature/edep-tally

Conversation

@melekderman
Copy link
Member

This pull request introduces support for tallying energy deposition ("edep") in mesh tallies. It adds the new "edep" score type, implements the logic for calculating energy deposition during neutron collisions, and ensures that energy deposition is only tallied in valid scenarios. The changes also include the necessary infrastructure to score and accumulate energy deposition results in mesh tallies.

Support for energy deposition ("edep") tallying:

  • Added new score type SCORE_EDEP for energy deposition to constant.py, and integrated it into the tally score system in tally.py and related modules. [1] [2] [3] [4] [5]
  • Restricted the use of the "edep" score to mesh tallies only and disallowed its combination with the "energy" multiplier.

Implementation of energy deposition calculation:

  • Refactored the neutron collision process to compute and return the energy deposited (edep_weighted) during each collision, including contributions from implicit capture, elastic/inelastic scattering, and fission. Updated the respective scattering and fission routines to return the appropriate weighted energy output for tallying. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]

Scoring and tallying infrastructure:

  • Implemented the mesh_tally_edep function in score.py to accumulate energy deposition scores in mesh tallies, including phase-space and mesh bin checks.
  • Updated the simulation loop to call mesh_tally_edep after each collision when appropriate.

@melekderman melekderman requested a review from ilhamv February 28, 2026 08:20
@melekderman melekderman added this to the v0.13.0 milestone Feb 28, 2026
@melekderman melekderman added the enhancement New feature or request label Feb 28, 2026
@ilhamv
Copy link
Member

ilhamv commented Mar 4, 2026

As discussed, the plan is to wait for the merge of #385, which reorganizes tally types by the estimator (tracklength, surface-crossing, and collision). The edep in this PR uses the collision estimator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants