fix(avc): prevent segfault in report-only mode (-out=report) #2025
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using -out=report mode, the encoder context (enc_ctx) is NULL because no output file needs to be created. The Rust FFI function ccxr_process_avc was dereferencing this NULL pointer, causing a segmentation fault. Add NULL pointer checks at the FFI boundary to skip AVC processing when enc_ctx is NULL. This is safe because report mode only needs stream analysis, not caption extraction. Fixes #2023 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 2028754...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 2028754...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-out=reporton transport streams with AVC/H.264 or HEVC videoccxr_process_avc()Root Cause
When using
-out=reportmode, the encoder context (enc_ctx) is intentionally NULL because no output file needs to be created. The Rust FFI function was dereferencing this NULL pointer without validation.Test plan
-out=reportno longer segfaults on H.264 streams-out=reportworks on HEVC streamsFixes #2023
🤖 Generated with Claude Code