Skip to content

fix(Wings): respect rotations from Rotations module - #8807

Open
minecrrrr wants to merge 5 commits into
CCBlueX:nextgenfrom
minecrrrr:Wings-Fix
Open

fix(Wings): respect rotations from Rotations module#8807
minecrrrr wants to merge 5 commits into
CCBlueX:nextgenfrom
minecrrrr:Wings-Fix

Conversation

@minecrrrr

@minecrrrr minecrrrr commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

When rotation is modified by the "Rotations" module, the wings fail to attach to the visual mode

@liquidbounce-support-bot

Copy link
Copy Markdown
Contributor

Thanks for the PR! I couldn't find an existing issue tracking this, so a short description would help the reviewers: what the wings look like without the fix (e.g. desync between wing direction and the visible model) and how to reproduce it.

Two small things a reviewer will likely bring up:

  • The when (ModuleRotations.enabled) blocks read more naturally as if/else, and the module state is checked twice — a single branch computing both rot and bodyRot would be simpler.
  • When the module is enabled but modelRotation/prevModelRotation are null, the code mixes a model-based value with an entity-based one per component; worth confirming that's intended rather than falling back to the entity rotations as a pair.

Nothing needed on the docs side.


🤖 Automated support reply — a human maintainer will review if this doesn't help.

@minecrrrr minecrrrr changed the title fix(Wings): ignore rotations from Rotations module fix(Wings): respect rotations from Rotations module Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant