Unit art implementation that also supports variations and pedia icons#915
Open
stavrosfa wants to merge 1 commit intoC7-Game:Developmentfrom
Open
Unit art implementation that also supports variations and pedia icons#915stavrosfa wants to merge 1 commit intoC7-Game:Developmentfrom
stavrosfa wants to merge 1 commit intoC7-Game:Developmentfrom
Conversation
esbudylin
reviewed
Mar 10, 2026
|
|
||
| function unit_icons:map_object_to_sprite(unit_prototype) | ||
| if (unit_prototype:GetType().Name ~= "UnitPrototype") then | ||
| local function isKeyInDictionary(dict, targetKey) |
Contributor
There was a problem hiding this comment.
If dict behaves like a regular Lua table, this function can be replaced by a one-liner: dict and dict[targetKey]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tackles something that was discussed a few months ago on discord, Unit art.
This is by no means how the final product should look like, it's rather a step towrads it.
In short this PR does the following:
Artobject that contains all the art for each unit.I tested this with .sav, .biq and .json, everything seemed to be in order
Let me know what you think on the proposed scheme for the art.
As I said, this doesn't need to remain as is in the future, as we can incorporate the INI details, custom animation details, etc, and finally even detach the whole Art json from the main json and have it as a separate one, but I think it's a good first step.
Also, this PR has a dependency on C7-Game/Assets#3